RFR (S): 8165226: Bad -Xloggc: arguments crashes the VM

[Marcus Larsson]

Thanks Stefan!


On 09/06/2016 02:49 PM, Stefan Johansson wrote:
> Hi Markus,
>
> On 2016-09-06 14:33, Marcus Larsson wrote:
>> Hi,
>>
>> Please review the following patch to fix a VM crash when 
>> LogConfiguration::parse_log_arguments() is called with a null pointer 
>> as the error stream.
>>
>> Summary:
>> LogConfiguration::parse_log_arguments() expects an outputStream to 
>> report errors on. Passing NULL works as long as no error occurs, but 
>> crashes the VM in case UL fails to configure the specified output. 
>> Usages of parse_log_arguments have been modified to pass an 
>> appropriate stream, and an assert checking for NULL has been added. 
>> Callers that use parse_log_arguments for configuration of stdout have 
>> been changed to use the more appropriate configure_stdout() instead.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~mlarsson/8165226/webrev.00/
>>
> Looks good,
> StefanJ
>> Issue:
>> https://bugs.openjdk.java.net/browse/JDK-8165226
>>
>> Testing:
>> JPRT testset hotspot
>>
>> Thanks,
>> Marcus
>