RFR(S) 8149607: [Verifier] Do not verify pop, pop2, swap, dup* against top

[Dmitry Dmitriev]

Thank you for clarification!

Dmitry

On 09.09.2016 18:25, harold seigel wrote:
> Hi Dmitry,
>
> I used version 51 in case this fix ever gets backported to JDK 8 or 
> JDK 7.  Since versions 51, 52, and 53 all use the same verifier, I 
> don't see a need for using different versions.
>
> Thanks, Harold
>
>
> On 9/9/2016 11:23 AM, Dmitry Dmitriev wrote:
>> Hello Harold,
>>
>> Small question about the test. All classes in popDupSwapTests.jasm 
>> have "version 51:0". Is it make sense to use different versions 
>> including the last one? Thank you!
>>
>> Dmitry
>>
>> On 31.08.2016 21:21, harold seigel wrote:
>>> Hi,
>>>
>>> Please review this verifier fix to disallow popping a single operand 
>>> of type 'top' from the stack in case it's the upper half of a long 
>>> or double operand.  See the Java Virtual Machine Spec 
>>> <http://docs.oracle.com/javase/specs/jvms/se8/html/jvms-4.html#jvms-4.10.1.2> 
>>> for information about type 'top' operands.
>>>
>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8149607
>>>
>>> Open webrev: http://cr.openjdk.java.net/~hseigel/bug_8149607/
>>>
>>> The fix was tested with the JCK Lang and VM tests, the hotpot, and 
>>> java/lang, java/util and other JTreg tests, and the NSK colocated 
>>> and non-colocated quick tests.
>>>
>>> Thanks, Harold
>>
>