RFR(XS): 8165613: Convert TestKlass_test to Gtest

[Kirill Zhaldybin]

Coleen,

Thank you for reviewing the fix!

Here are a new WebRev: 
http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8165613/webrev.01/

I changed the test name and moved it to the appropriate location.

Could you please let me know your opinion?

Thank you.

Regards, Kirill

On 12.09.2016 15:28, Coleen Phillimore wrote:
>
> This looks good but I'm confused about something:
>
> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8165613/webrev.00/test/native/oops/test_klass.cpp.html 
>
>
>   28 TEST_VM(SystemDictionary, class_loader_class) {
>
>
> It seems like making the tests test the SystemDictionary is more 
> appropriate than InstanceKlass, which I think this does.  If so, can  
> you move the test file to the directory 
> test/native/classfile/test_systemDictionary.cpp (or whatever the 
> convention is), if it exists?
>
> Thanks,
> Coleen
>
> On 9/12/16 8:15 AM, Kirill Zhaldbybin wrote:
>> Robert,
>>
>> Thank you for review!
>>
>> Regards, Kirill
>>
>> On 09/12/2016 11:35 AM, Robbin Ehn wrote:
>>> Looks good.
>>>
>>> Thanks!
>>>
>>> /Robbin (not a 'R'eviewer)
>>>
>>> On 09/08/2016 04:48 PM, Kirill Zhaldybin wrote:
>>>> Dear all,
>>>>
>>>> Could you please review this fix for 8165613?
>>>>
>>>> WebRev: 
>>>> http://cr.openjdk.java.net/~kzhaldyb/webrevs/JDK-8165613/webrev.00/
>>>> CR: https://bugs.openjdk.java.net/browse/JDK-8165613
>>>>
>>>> Thank you.
>>>>
>>>> Regards, Kirill
>>
>