RFR: (XS): 8136766: Enable ThreadStackSize range test
Gerard Ziemski
gerard.ziemski at oracle.com
Fri Sep 16 16:57:42 UTC 2016
Thank you Dan for the review.
> On Sep 15, 2016, at 3:16 PM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
>
> On 9/15/16 8:27 AM, Gerard Ziemski wrote:
>> hi all,
>>
>> Please review this XS fix, where we enable MAX range testing in hotspot/test/runtime/CommandLine/OptionsValidation, now that JDK-8140520 has been fixed (thank you Ron and Dan)
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8136766
>> webrev: http://cr.openjdk.java.net/~gziemski/8136766_rev1
>
> test/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java
> No comments.
>
> The fix does what it claims which is fine. Thumbs up!
>
> Caveat: I do remember that Ron ran into issues with enabling the MAX range
> testing for these three options on some Solaris SPARC machines. I'm fairly
> certain he said some of the Solaris SPARC test machines hung at the kernel
> level and had to rebooted due to swap space issues. Don't know if the
> machines were mis-configured or what, but I thought I send up a flare.
The test doesn’t run by default, so the risk is small, but it’s something to keep in mind.
cheers
More information about the hotspot-runtime-dev
mailing list