RFR: 8163014: Mysterious/wrong value for "long" frame local variable on 64-bit

Coleen Phillimore coleen.phillimore at oracle.com
Thu Sep 22 03:47:52 UTC 2016


Since this is in the aarch64 directory and it looks good to me, I think 
you can consider it Reviewed and just push the change.
Thanks,
Coleen

On 9/21/16 11:40 PM, Ningsheng Jian wrote:
> On 21 September 2016 at 17:13, Andrew Dinn <adinn at redhat.com> wrote:
>> On 21/09/16 05:45, Ningsheng Jian wrote:
>>> Hi Max,
>>>
>>> This patch breaks aarch64 build with:
>>>
>>> error: ‘wordsize’ was not declared in this scope
>>>
>>> I think it is a typo for "wordSize" at line below:
>>>
>>>   330   str(r, pre(esp, -wordsize));
>> Apologies for this -- it is my fault. I introduced the spelling mistake
>> when I transcribed my revision of Max's patch into email. I guess I
>> should have sent him a webrev but I merely wanted to highlight the error
>> in the AArch64 part of the patch.
>>
>> n.b. Before replying to Max I applied the patch lines as shown above
>> except with correct spelling as wordSize and the corresponding test
>> passed on AArch64. So, correcting this typo should correct the problem.
> Yes, correcting the typo can fix the issue.
>
>> regards,
>>
>>
>> Andrew Dinn
>> -----------
>> Senior Principal Software Engineer
>> Red Hat UK Ltd
>> Registered in England and Wales under Company Registration No. 03798903
>> Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
>>



More information about the hotspot-runtime-dev mailing list