RFR(S): 8160064: StackWalker implementation added logging option without using UL
Mandy Chung
mandy.chung at oracle.com
Wed Sep 28 17:19:54 UTC 2016
> On Sep 28, 2016, at 10:15 AM, Rachel Protacio <rachel.protacio at oracle.com> wrote:
>
> Thanks for the review!
>
>
> On 9/28/2016 12:58 PM, Mandy Chung wrote:
>>
>>> On Sep 28, 2016, at 9:40 AM, Rachel Protacio <rachel.protacio at oracle.com> wrote:
>>>
>>> Updated webrev: http://cr.openjdk.java.net/~rprotacio/8160064.01/
>>>
>>> Includes simplified test, log_is_enabled checks, and logging on debug level.
>>>
>> Thanks for updating the test which looks good.
>>
>> log_debug is used in this version. Does that mean the logging can’t be used in product jvm?
>>
>> As Coleen indicates, since there is no impact to the performance and JVM code size, making stackwalk logging a product level flag would be useful for core-libs team.
> log_debug refers to the level of logging. It is in product mode.
That’s good. Thanks for the clarification.
+1
Mandy
More information about the hotspot-runtime-dev
mailing list