RFR(S): 8160064: StackWalker implementation added logging option without using UL

David Holmes david.holmes at oracle.com
Thu Sep 29 03:49:42 UTC 2016


On 29/09/2016 2:40 AM, Rachel Protacio wrote:
> Updated webrev: http://cr.openjdk.java.net/~rprotacio/8160064.01/
>
> Includes simplified test, log_is_enabled checks, and logging on debug
> level.

  src/share/vm/prims/stackwalk.cpp

  379         tty->cr();

should be: st->cr();

  452   log_debug(stackwalk)("StackWalk::fetchNextBatch frame_count %d 
existing_stream "
  453                        PTR_FORMAT " start %d frames %d",
  454                        frame_count,
  455                        p2i(existing_stream),
  456                        start_index,
  457                        frames_array->length());

Nit: no need for an argument per line. I think this should all fit on 3 
lines total.

No further comments :)

Thanks,
David

> Thanks,
> Rachel
>
> On 9/27/2016 3:47 PM, Rachel Protacio wrote:
>> Hi,
>>
>> Please review this small fix correcting the StackWalker print output
>> mechanism by moving it to Unified Logging. Includes a new jtreg test,
>> and passes JPRT.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8160064
>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8160064/
>>
>> Thank you!
>> Rachel
>


More information about the hotspot-runtime-dev mailing list