RFR(S) 8178118: Arguments::create_numbered_property allocates wrong buffer in case count > 99

David Holmes david.holmes at oracle.com
Thu Apr 6 04:47:59 UTC 2017

Hi Katya,

On 6/04/2017 7:24 AM, Ekaterina Pavlova wrote:
> Hi everyone,
> Please review this change that fixes memory allocation in Arguments::create_numbered_property.
> Also added error messages so java prints some hints except just exiting with "Error: Could not create the Java Virtual Machine"
> (tested by adding error in 'prop_len' calculation).
> This is perhaps zero day bug but it was recently discovered when testing with multiple '-add-exports' options.
>    bug: https://bugs.openjdk.java.net/browse/JDK-8178118
> webrev:  http://cr.openjdk.java.net/~iignatyev/epavlova/8178118/

Looks good.

One nit. I would have found it easier to understand if 
props_count_limit_log10 had been called max_digits (or something like that).


> Tested by running jprt.
> -katya

More information about the hotspot-runtime-dev mailing list