RFR(S) 8178118: Arguments::create_numbered_property allocates wrong buffer in case count > 99

[coleen.phillimore at oracle.com]

This is for jdk10 right?
thanks,
Coleen

On 4/6/17 12:47 AM, David Holmes wrote:
> Hi Katya,
>
> On 6/04/2017 7:24 AM, Ekaterina Pavlova wrote:
>> Hi everyone,
>>
>> Please review this change that fixes memory allocation in 
>> Arguments::create_numbered_property.
>> Also added error messages so java prints some hints except just 
>> exiting with "Error: Could not create the Java Virtual Machine"
>> (tested by adding error in 'prop_len' calculation).
>> This is perhaps zero day bug but it was recently discovered when 
>> testing with multiple '-add-exports' options.
>>
>>    bug: https://bugs.openjdk.java.net/browse/JDK-8178118
>> webrev:  http://cr.openjdk.java.net/~iignatyev/epavlova/8178118/
>
> Looks good.
>
> One nit. I would have found it easier to understand if 
> props_count_limit_log10 had been called max_digits (or something like 
> that).
>
> Thanks,
> David
>
>> Tested by running jprt.
>>
>> -katya
>>