RFR 8150388: Remove SPARC 32-bit support
Vladimir Kozlov
vladimir.kozlov at oracle.com
Tue Apr 11 19:23:27 UTC 2017
In globalDefinitions_gcc.hpp next changes are strange - it is not related to SPARC. We still support 32-bit linux on x86
(I agree with with last APPLE change).
#ifdef __GNUC__
- #ifdef _LP64
#define NULL_WORD 0L
- #else
- // Cast 0 to intptr_t rather than int32_t since they are not the same type
- // on platforms such as Mac OS X.
- #define NULL_WORD ((intptr_t)0)
- #endif
#else
// Formatting.
-#ifdef _LP64
#define FORMAT64_MODIFIER "l"
-#else // !_LP64
-#define FORMAT64_MODIFIER "ll"
-#endif // _LP64
Otherwise changes are good.
Thanks,
Vladimir
On 4/11/17 11:09 AM, George Triantafillou wrote:
> Here's an updated webrev addressing changes from Vladimir, Harold, and David:
>
> http://cr.openjdk.java.net/~gtriantafill/8150388-webrev/webrev.03/
> <http://cr.openjdk.java.net/%7Egtriantafill/8150388-webrev/webrev.03/>
>
> Thanks.
>
> -George
>
> On 4/7/2017 11:04 AM, George Triantafillou wrote:
>> Thanks Harold, I've made the suggested changes.
>>
>> -George
>>
>> On 4/7/2017 10:34 AM, harold seigel wrote:
>>> Hi George,
>>>
>>> Most of the changes look good. A few comments:
>>>
>>> 1. In stubGenerator_sparc.cpp, lines 831-835 should not be deleted, just the "&& defined(_LP64)"
>>>
>>> 831 #if defined(ASSERT) && defined(_LP64)
>>> 832 __ signx(Rint, Rtmp);
>>> 833 __ cmp(Rint, Rtmp);
>>> 834 __ breakpoint_trap(Assembler::notEqual, Assembler::xcc);
>>> 835 #endif
>>>
>>> 2. In atomic_solaris_sparc.hpp: remove lines 245 and 372
>>>
>>> 3. In prefetch_solaris_sparc.inline, remove lines 30 and 63
>>>
>>> 4. In thread_solaris_sparc.hpp, remove line 67.
>>>
>>> Thanks, Harold
>>>
>>> On 4/7/2017 9:43 AM, George Triantafillou wrote:
>>>> Please review this fix to remove SPARC 32-bit support. Support for solaris-sparc has been dropped from the list of
>>>> supported platforms.
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8150388
>>>> webrev: http://cr.openjdk.java.net/~gtriantafill/8150388-webrev/webrev/
>>>> <http://cr.openjdk.java.net/%7Egtriantafill/8150388-webrev/webrev/>
>>>>
>>>> Built and tested on solaris-sparcv9-debug,solaris-x64-debug with the nsk.jvmti, nsk.jdwp, and nsk.jdi testlists.
>>>>
>>>> Thanks.
>>>>
>>>> -George
>>>>
>>>
>>
>
More information about the hotspot-runtime-dev
mailing list