RFR(L): 10: JDK-8177728 - [TESTBUG] Improve CDS test utils

[Mikhailo Seledtsov]

Hi Calvin,

   Thank you for review. I will fix the typos and copyright changes 
before check-in.


Misha

On 4/18/17, 10:51 AM, Calvin Cheung wrote:
> Hi Misha,
>
> Thanks for the update.
> Few minor comments below.
>
> On 4/13/17, 7:33 PM, Mikhailo Seledtsov wrote:
>> Jiangli,
>>
>> Thank you for review. I fixed TransformRelatedClasses.java to use new 
>> CDSTestUtils.
>> Here are updated webrevs that address feedback from you and Calvin.
>>
>> http://cr.openjdk.java.net/~mseledtsov/8177728.01.top/
> CDSTestUtils.java
>
> 338 // ===================== FILE ACCESS convinience methods
>
> convinience -> convenience
>> http://cr.openjdk.java.net/~mseledtsov/8177728.01.hotspot/
> BootAppendTests.java
>
>
> 76 // This test case is currently failing
> 77 // TODO: Resolve prior to the final review and integration
> 78 // log("TESTCASE: 2");
> 79 // testBootAppendDuplicateModuleClass();
>
> Is the test scenario still failing?
> Maybe file another bug to followup on this?
>
> SharedStrings.java
>
> 47 // This also servces as a reference on how to use this feature,
>
> servces -> serves
>
>
> Below files have the same copyright year problem:
>
> BootAppendTests.java
> LargeSharedSpace.java
> SASymbolTableTest.java
> SharedStringsDedup.java
> TestInterpreterMethodEntries.java
> TransformRelatedClasses.java
> TransformTestCommon.java
>
> 2 * Copyright (c) 2017, Oracle and/or its affiliates. All rights 
> reserved.
>
> Need to keep the original year.
>
> * Copyright (c) 2016, 2017, …
>
> I don't need to see another webrevs for the typos and copyright year 
> changes.
>
> thanks,
> Calvin
>>
>> Thank you,
>> Misha
>>
>> On 4/4/17, 5:53 PM, Jiangli Zhou wrote:
>>> Hi Misha,
>>>
>>> Looks good. TransformRelatedClasses.java was not changed to use the 
>>> utility methods. Was that on purpose?
>>>
>>> Thanks,
>>> Jiangli
>>>
>>>> On Mar 28, 2017, at 3:09 PM, 
>>>> mikhailo<mikhailo.seledtsov at oracle.com> wrote:
>>>>
>>>> Please review this enhancement to CDS tests (RFE)
>>>>
>>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8177728
>>>> Webrevs:
>>>> http://cr.openjdk.java.net/~mseledtsov/8177728.00.hotspot/
>>>> http://cr.openjdk.java.net/~mseledtsov/8177728.00.top/
>>>>
>>>>
>>>> Here is a brief summary of the improvements:
>>>> - create/use CDS utility methods for common patterns in CDS related 
>>>> tests:
>>>> - creating an testlist
>>>> - creating an archive, checking result
>>>> - executing JVM with the archive
>>>> - checking results and common error patterns
>>>>
>>>> - use -Xshare:on when executing CDS tests, and use test utilities
>>>> to filter out failures due to inability to map shared archive.
>>>> This is a more deterministic way to execute CDS tests.
>>>>
>>>> - additional improvements came up as part of this work,
>>>> such as jdk.test.lib.Utils:getTestName()
>>>>
>>>> This work also lays ground for future improvements in this area.
>>>>
>>>>
>>>> Testing:
>>>> 1. Locally: executed affected tests on Linux-x64
>>>> (hotspot/test/runtime/SharedArchiveFile)
>>>> PASS
>>>>
>>>> 2. Automated multi-platform testing
>>>> Running the affected tests on a set of supported platforms.
>>>> IN Progress...
>>>>
>>>> Thank you,
>>>> Misha
>>>>