RFR(xs): 8179103: [Testbug] re-enable the runtime/SharedArchiveFile/BootAppendTests.java test

[Ioi Lam]

I think it's better to use CDSTestUtils.checkExec which will check a 
bunch of other conditions:

OutputAnalyzer out = CDSTestUtils.runWithArchive(opts);
CDSTestUtils.checkExec(out, "java.lang.ClassNotFoundException: 
javax.sound.sampled.MyClass");

Thanks
- Ioi


On 4/25/17 12:18 AM, Calvin Cheung wrote:
> I turns out that the fix needs to be updated to account for the 
> "unable to map archive" error on platfoms such as windows 32-bit. The 
> following updated webrev passed all hotspot_runtime tests on all 
> applicable platforms.
>
> http://cr.openjdk.java.net/~ccheung/8179103/webrev.01/
>
> Change pattern is as follows:
>
> before:
>              CDSTestUtils.runWithArchive(opts)
>                  .shouldContain("java.lang.ClassNotFoundException: 
> javax.sound.sampled.MyClass");
>
> after:
>              OutputAnalyzer out = CDSTestUtils.runWithArchive(opts);
>              if (!CDSTestUtils.isUnableToMap(out)) {
> out.shouldContain("java.lang.ClassNotFoundException: 
> javax.sound.sampled.MyClass");
>              }
>
> thanks,
> Calvin
>
> On 4/21/17, 6:25 PM, Calvin Cheung wrote:
>> Thanks Jiangli!
>> I'll wait until the testing is done before pushing the fix.
>>
>> thanks,
>> Calvin
>>
>> On 4/21/17, 6:06 PM, Jiangli Zhou wrote:
>>> Looks good.
>>>
>>> Thanks,
>>> Jiangli
>>>
>>>> On Apr 21, 2017, at 3:18 PM, Calvin 
>>>> Cheung<calvin.cheung at oracle.com>  wrote:
>>>>
>>>> Hi,
>>>>
>>>> Please review this simple fix for re-enabling a test case.
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8179103
>>>>
>>>> webrev: http://cr.openjdk.java.net/~ccheung/8179103/webrev.00/
>>>>
>>>> Tested locally on linux-x64.
>>>> Running tests on other platforms.
>>>>
>>>> thanks,
>>>> Calvin