RFR (not as big as it looks) 8184994: Add Dictionary size logging and jcmd

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Tue Aug 1 17:32:33 UTC 2017


On 8/1/17 1:19 PM, Aleksey Shipilev wrote:
> On 08/01/2017 07:14 PM, coleen.phillimore at oracle.com wrote:
>>> *) systemDictionary.cpp: in SystemDictionary::dump, the if(verbose) condition seems inverted. Should
>>> dump tables when verbose?
>> I kept the name dump_table from the VM.stringtable and VM.symboltable dcmd code, when the function
>> really prints hashtable statistics.   I could rename that function to be print_table_statistics()
>> instead.  And change ClassLoaderDataGraph::dump_dictionary to print_dictionary_statistics.  If that
>> makes sense.
> Yeah, that would make sense.

Thanks!  Here's a webrev with the renaming:

open webrev at http://cr.openjdk.java.net/~coleenp/8184994.02/webrev

and tested.

Thanks,
Coleen

>
> Thanks,
> -Aleksey
>



More information about the hotspot-runtime-dev mailing list