RFR (not as big as it looks) 8184994: Add Dictionary size logging and jcmd

[harold seigel]

Hi Coleen,

Other than this erroneous comment in diagnosticCommand.hpp, the change 
looks good:

    735 // VM.systemdictionary -verbose: for dumping the*string table*

Go ahead and push it.

Thanks, Harold

On 8/1/2017 1:32 PM, coleen.phillimore at oracle.com wrote:
>
>
> On 8/1/17 1:19 PM, Aleksey Shipilev wrote:
>> On 08/01/2017 07:14 PM, coleen.phillimore at oracle.com wrote:
>>>> *) systemDictionary.cpp: in SystemDictionary::dump, the if(verbose) 
>>>> condition seems inverted. Should
>>>> dump tables when verbose?
>>> I kept the name dump_table from the VM.stringtable and 
>>> VM.symboltable dcmd code, when the function
>>> really prints hashtable statistics.   I could rename that function 
>>> to be print_table_statistics()
>>> instead.  And change ClassLoaderDataGraph::dump_dictionary to 
>>> print_dictionary_statistics.  If that
>>> makes sense.
>> Yeah, that would make sense.
>
> Thanks!  Here's a webrev with the renaming:
>
> open webrev at http://cr.openjdk.java.net/~coleenp/8184994.02/webrev
>
> and tested.
>
> Thanks,
> Coleen
>
>>
>> Thanks,
>> -Aleksey
>>
>