RFR 8185717: Make ModuleEntry->module() return an oop not a jobject

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Mon Aug 7 15:06:22 UTC 2017



On 8/7/17 9:34 AM, Aleksey Shipilev wrote:
> On 08/07/2017 03:26 PM, harold seigel wrote:
>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8185717/webrev/index.html
> So this just moves JNIHandles::resolve calls into ModuleEntry::module(), and exposes
> ModuleEntry::module_handle() in case we can do with the original (global?) handle.

Yes, we can change the representation without having to fix all these 
places.  If you look at ClassLoaderData::_handles, it's not a 
JNIHandleBlock anymore, so these really aren't JNIHandles or jobject.  
This was because JNIHandleBlock couldn't be concurrently walked.  The 
global handle and weak handle list has the same problem.  We're (Kim is) 
currently working on a replacement for this, which needs an RFE.

thanks,
Coleen

>
> This looks correct.
>
> Thanks,
> -Aleksey
>
>



More information about the hotspot-runtime-dev mailing list