RFR(XS): JDK-8186154 : Extra info with +LogTouchedMethods

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Mon Aug 14 15:32:26 UTC 2017



On 8/14/17 11:07 AM, Vladimir Kozlov wrote:
> On 8/14/17 5:07 AM, coleen.phillimore at oracle.com wrote:
>>
>> Hi,
>>
>> I don't think you should add another option to print the count. You 
>> should do it unconditionally.  Since it's a diagnostic option, we 
>> don't have to support parsers of the output.
>
> Not true. Please, don't complicate PrintTouchedMethodsAtExit output 
> because AOT have to parse it ;) as Eric explained.

I didn't see that.  Can we also fix AOT to parse and/or ignore the 
count?  I thought the purpose was for AOT to get the count to provide a 
better list to precompile.

thanks,
Coleen

>
> If you want an other output use -Xlog format.
>
> Vladimir
>
>> I was going to type that you should use UL for this output instead, 
>> but that's a bigger task.  It would be nice if the compiler options 
>> used UL and didn't have these Print options anymore.  In any case, 
>> please don't add another Print* option.
>>
>> thanks,
>> Coleen
>>
>> On 8/11/17 3:10 PM, Eric Caspole wrote:
>>> Hi,
>>> Please review this very small change to add more info to 
>>> +LogTouchedMethods including the touched count and whether the 
>>> method has loops. This extra info has been handy while doing 
>>> experiments to create the most efficient AOT library for quick startup.
>>>
>>> http://cr.openjdk.java.net/~ecaspole/JDK-8186154/webrev/
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8186154
>>>
>>> Passed JPRT hotspot tests.
>>>
>>> Thanks,
>>> Eric
>>



More information about the hotspot-runtime-dev mailing list