RFR(xxs): 8186199: [windows] JNI_DestroyJavaVM not covered by SEH

David Holmes david.holmes at oracle.com
Tue Aug 15 11:26:24 UTC 2017


On 15/08/2017 5:17 PM, Thomas Stüfe wrote:
> Modified the change a bit to avoid theoretical problems should we ever 
> want C++ expeptions. This also is more consistent with the way we use 
> _try/__except for CreateJavaVM.

Okay ... not sure what difference it makes though.

David

> New Webrev: 
> http://cr.openjdk.java.net/~stuefe/webrevs/8186199-destroyjavavm-no-seh-handler/webrev.01/webrev/
> 
> Thanks, Thomas
> 
> 
> 
> On Mon, Aug 14, 2017 at 5:23 PM, Thomas Stüfe <thomas.stuefe at gmail.com 
> <mailto:thomas.stuefe at gmail.com>> wrote:
> 
>     Dear all,
> 
>     please review this tiny fix:
> 
>     Issue: https://bugs.openjdk.java.net/browse/JDK-8186199
>     <https://bugs.openjdk.java.net/browse/JDK-8186199>
>     webrev:
>     http://cr.openjdk.java.net/~stuefe/webrevs/8186199-destroyjavavm-no-seh-handler/webrev.00/webrev/
>     <http://cr.openjdk.java.net/~stuefe/webrevs/8186199-destroyjavavm-no-seh-handler/webrev.00/webrev/>
> 
>     We miss __try{ } __except in JNI_DestroyJavaVM, so we run without
>     signal handler (well, SE handler) during the invocation of
>     JNI_DestroyJavaVM.
> 
>     Thanks, Thomas
> 
> 


More information about the hotspot-runtime-dev mailing list