RFR (S): 8186238: The constant pool entry to empty string ("") should not be pre-resolved during CDS dump time

[Jiangli Zhou]

Thank you, Dan!

Jiangli

> On Aug 15, 2017, at 3:07 PM, Daniel D. Daugherty <daniel.daugherty at oracle.com> wrote:
> 
> On 8/15/17 3:59 PM, Jiangli Zhou wrote:
>> Hi,
>> 
>> Please review the following fix for JDK-8186238 <https://bugs.openjdk.java.net/browse/JDK-8186238>. Empty string “” is excluded from the shared string table at CDS dump time. During pre-resolving the constant pool string entries at dump time, the entries to the empty string should be skipped, otherwise different instances might be returned when calling intern() on empty string at runtime.
>> 
>> webrev: http://cr.openjdk.java.net/~jiangli/8186238/webrev.00/
> 
> src/share/vm/oops/constantPool.cpp
>    No comments.
> 
> Thumbs up!
> 
> Ioi said to list him as a reviewer since he saw the fix in
> another e-mail thread.
> 
> I think the HotSpot trivial fix rule applies and you do not
> have to wait for 24 hours.
> 
> Dan
> 
> 
>> bug:    https://bugs.openjdk.java.net/browse/JDK-8186238
>> 
>> Tested with the failed tests shown in nightly.
>> 
>> Thanks,
>> Jiangli
>> 
>