RFR(xxs): 8186199: [windows] JNI_DestroyJavaVM not covered by SEH

Thomas Stüfe thomas.stuefe at gmail.com
Thu Aug 17 11:34:17 UTC 2017


Danke :)

On Aug 17, 2017 12:56, "Doerr, Martin" <martin.doerr at sap.com> wrote:

> Hi Thomas,
>
> looks good. Thanks. I also like that DestroyJavaVM looks more like
> CreateJavaVM, now.
>
> Best regards,
> Martin
>
>
> -----Original Message-----
> From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
> bounces at openjdk.java.net] On Behalf Of Thomas Stüfe
> Sent: Mittwoch, 16. August 2017 16:18
> To: hotspot-runtime-dev at openjdk.java.net
> Subject: Re: RFR(xxs): 8186199: [windows] JNI_DestroyJavaVM not covered by
> SEH
>
> Ping.. could I please have a second review and a sponsor? Thank you!
>
> Current webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8186199-
> destroyjavavm-no-seh-handler/webrev.01/webrev/
>
> ..Thomas
>
> On Mon, Aug 14, 2017 at 5:23 PM, Thomas Stüfe <thomas.stuefe at gmail.com>
> wrote:
>
> > Dear all,
> >
> > please review this tiny fix:
> >
> > Issue: https://bugs.openjdk.java.net/browse/JDK-8186199
> > webrev: http://cr.openjdk.java.net/~stuefe/webrevs/
> > 8186199-destroyjavavm-no-seh-handler/webrev.00/webrev/
> >
> > We miss __try{ } __except in JNI_DestroyJavaVM, so we run without signal
> > handler (well, SE handler) during the invocation of JNI_DestroyJavaVM.
> >
> > Thanks, Thomas
> >
>


More information about the hotspot-runtime-dev mailing list