RFR: 8186706: ArchivedObjectCache obj_hash() is broken
Jiangli Zhou
jiangli.zhou at oracle.com
Thu Aug 24 01:04:57 UTC 2017
Thanks!
Jiangli
> On Aug 23, 2017, at 5:20 PM, Calvin Cheung <calvin.cheung at oracle.com> wrote:
>
> Hi Jiangli,
>
> The change looks good to me.
>
> thanks,
> Calvin
>
> On 8/23/17, 4:24 PM, Jiangli Zhou wrote:
>> Please review the following webrev that fixes the ArchivedObjectCache obj_hash() issue. The patch was from Ioi (thanks!). I will count myself as a reviewer.
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8186706?filter=14921
>> webrev: http://cr.openjdk.java.net/~jiangli/8186706/webrev.00/
>>
>> ArchivedObjectCache obj_hash() computes hash using incorrect address. The fix is to use the correct oop address. The default ResourceHashtable size is 256, which is too small when large number of objects are archived. The table is now changed to use a much larger (15889) size. The ArchivedObjectCache issue was noticed when one test times out on slower linux arm64 machine. With the fix the test finishes without timeout.
>>
>> Tested with tier4-comp tests.
>>
>> Thanks,
>> Jiangli
More information about the hotspot-runtime-dev
mailing list