RFR(XXS) 8186748: NMT: memTracker::record_virtual_memory_reserve_and_commit() does not tag the memory as committed
coleen.phillimore at oracle.com
coleen.phillimore at oracle.com
Thu Aug 24 19:35:37 UTC 2017
You are welcome. I don't this change needs a 24 hour wait.
Coleen
On 8/24/17 3:04 PM, Zhengyu Gu wrote:
> On 08/24/2017 02:50 PM, coleen.phillimore at oracle.com wrote:
>>
>> This looks good. I assume that you ran the NMT tests on it. I'll
>> sponsor it.
>> Coleen
>
> Yes, I ran jtreg NMT tests.
>
> Thanks so much for the review and sponsorship, again!
>
> -Zhengyu
>
>
>>
>>
>> On 8/24/17 2:29 PM, Zhengyu Gu wrote:
>>> Please review this one line change to fix missing tag of committed
>>> memory region.
>>>
>>> The bug results NMT to report "Shared class space" as reserved, but
>>> not committed region.
>>>
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8186748
>>> Webrev: http://cr.openjdk.java.net/~zgu/8186748/webrev.00/
>>>
>>>
>>>
>>> Before:
>>>
>>> - Shared class space (reserved=16904KB, committed=0KB)
>>> (mmap: reserved=16904KB, committed=0KB)
>>>
>>> After:
>>>
>>> - Shared class space (reserved=16832KB, committed=16832KB)
>>> (mmap: reserved=16832KB, committed=16832KB)
>>>
>>>
>>> Thanks,
>>>
>>> -Zhengyu
>>
More information about the hotspot-runtime-dev
mailing list