RFR (S) 8164207: Checking missing load-acquire in relation to _pd_set in dictionary.cpp

Zhengyu Gu zgu at redhat.com
Thu Aug 24 20:07:44 UTC 2017


Hi Coleen,

There are two instances probably overlooked?

dictionary.cpp #103 and #124

     for (ProtectionDomainEntry* current = _pd_set;
=>
     for (ProtectionDomainEntry* current = pd_set();


Thanks,

-Zhengyu

On 08/24/2017 02:28 PM, coleen.phillimore at oracle.com wrote:
> Summary: Use load_acquire for accessing DictionaryEntry::_pd_set since 
> it's accessed outside the SystemDictionary_lock
> 
> Ran parallel class loading tests that we have as well as tier1 tests. 
> See bug for details.
> 
> open webrev at http://cr.openjdk.java.net/~coleenp/8164207.01/webrev
> bug link https://bugs.openjdk.java.net/browse/JDK-8164207
> 
> Thanks,
> Coleen
> 


More information about the hotspot-runtime-dev mailing list