RFR(XXS) JDK-8186778 Deprecate VM options for shared region size control

[David Holmes]

On 26/08/2017 6:02 AM, Ioi Lam wrote:
> If I understand the comments above my changes in arguments.cpp correctly, there are 3 stage of removing options - deprecated, obsolete and removed. I am at stage 1 now, so the options are kept in globals.hpp

Except you haven't actually deprecated these options you have made them 
obsolete as they are now ignored by the VM. If they were only deprecated 
then the VM would still use them.

I think you will need to redo this and the CSR as an obsoletion request.

Thanks,
David

> Thanks
> Ioi
> 
>> On Aug 25, 2017, at 12:11 PM, Jiangli Zhou <jiangli.zhou at oracle.com> wrote:
>>
>> Hi Ioi,
>>
>> The change looks good. I noticed the deprecated options (not just the ones you are adding) are still kept in globals.hpp. Do you know why we didn’t remove them from globals.hpp?
>>
>> Thanks,
>> Jiangli
>>
>>> On Aug 25, 2017, at 11:19 AM, Ioi Lam <ioi.lam at oracle.com> wrote:
>>>
>>> Hi, please review this very small change. The corresponding CSR has been approved.
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8186778
>>>
>>> Since JDK-8072061 (Automatically determine optimal sizes for the CDS regions) is integrated,
>>> the following 4 options are no longer necessary, and they are no longer used by the VM
>>> anymore. Hence, these options should be deprecated:
>>>
>>>     SharedReadWriteSize
>>>     SharedReadOnlySize
>>>     SharedMiscDataSize
>>>     SharedMiscCodeSize
>>>
>>> hotspot$ hg diff
>>> diff -r 3a8e59bdaaac src/share/vm/runtime/arguments.cpp
>>> --- a/src/share/vm/runtime/arguments.cpp    Thu Aug 24 14:00:04 2017 +0000
>>> +++ b/src/share/vm/runtime/arguments.cpp    Fri Aug 25 11:16:29 2017 -0700
>>> @@ -379,6 +379,10 @@
>>> static SpecialFlag const special_jvm_flags[] = {
>>>    // -------------- Deprecated Flags --------------
>>>    // --- Non-alias flags - sorted by obsolete_in then expired_in:
>>>    { "MaxGCMinorPauseMillis", JDK_Version::jdk(8), JDK_Version::undefined(), JDK_Version::undefined() },
>>>    { "UseConcMarkSweepGC",    JDK_Version::jdk(9), JDK_Version::undefined(), JDK_Version::undefined() },
>>>    { "MonitorInUseLists", JDK_Version::jdk(10),JDK_Version::undefined(), JDK_Version::undefined() },
>>> +  { "SharedMiscCodeSize", JDK_Version::jdk(10),JDK_Version::undefined(), JDK_Version::undefined() },
>>> +  { "SharedMiscDataSize", JDK_Version::jdk(10),JDK_Version::undefined(), JDK_Version::undefined() },
>>> +  { "SharedReadOnlySize", JDK_Version::jdk(10),JDK_Version::undefined(), JDK_Version::undefined() },
>>> +  { "SharedReadWriteSize", JDK_Version::jdk(10),JDK_Version::undefined(), JDK_Version::undefined() },
>>>
>>>    // --- Deprecated alias flags (see also aliased_jvm_flags) - sorted by obsolete_in then expired_in:
>>>    { "DefaultMaxRAMFraction", JDK_Version::jdk(8), JDK_Version::undefined(), JDK_Version::undefined() },
>>>
>>
>>
>>
>>
>>
>