RFR(S) 8186770: NMT: Report metadata information in NMT summary

[Andrew Dinn]

On 29/08/17 15:59, Zhengyu Gu wrote:

>>> Make sense to report *waste*. How about
>>>                                (  Metadata:                            )
>>>                                (    reserved=22528KB, 
>>> committed=21504KB)
>>>                                (    capacity=21327KB,   used=20654KB)
>>>                                (    free chunks=113KB)
>>>                                (    available=0KB)
>>>                                (    waste = 560KB = 2.6%)
>> Yes, agreed except that I mentioned I think it is tidier to put free
>> chinks and available on the same line as I did above? Do you have a
>> reason for not following that suggestion?
> Yes. Because they are unrelated.
> 
> e.g.
> 
> *committed* belongs to *reserved*
> *used* is part of *capacity*
> 
> but free chunks and available do not relate to each other.
Ok, I can see where you are coming from now. However, while you are
right that used is part of capacity you can also consider it true that
free_chunks, available and waste belong to/are part of capacity. Those
four figures constitute four different components of the total capacity.
Perhaps something like this might make that clearer?

                           (  Metadata:                            )
                           (    reserved=22528KB,  committed=21504KB)
                           (    capacity=21327KB,  used=20654KB)
                           (                       free chunks=113KB)
                           (                       available=0KB)
                           (                       waste = 560KB = 2.6%)

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander