RFR(XXXS): 8192810 - EnableThreadSMRStatistics should be default off in release builds

Daniel D. Daugherty daniel.daugherty at oracle.com
Fri Dec 1 15:50:34 UTC 2017


Thanks George!

Dan


On 12/1/17 10:49 AM, George Triantafillou wrote:
> Hi Dan,
>
> Looks good!
>
> -George
>
>
> On 12/1/2017 10:18 AM, Daniel D. Daugherty wrote:
>> Greetings,
>>
>> Trivial fix here so I need a single (R)eviewer for this one.
>>
>> 8192810 EnableThreadSMRStatistics should be default off in release 
>> builds
>> https://bugs.openjdk.java.net/browse/JDK-8192810
>>
>> $ hg diff
>> diff -r 61a14b5cb1c6 src/hotspot/share/runtime/globals.hpp
>> --- a/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 18:19:39 
>> 2017 +0530
>> +++ b/src/hotspot/share/runtime/globals.hpp    Fri Dec 01 10:15:47 
>> 2017 -0500
>> @@ -2488,7 +2488,7 @@
>>    diagnostic(bool, EnableThreadSMRExtraValidityChecks, 
>> true,                \
>>               "Enable Thread SMR extra validity 
>> checks")                     \
>> \
>> -  diagnostic(bool, EnableThreadSMRStatistics, 
>> true,                         \
>> +  diagnostic(bool, EnableThreadSMRStatistics, 
>> trueInDebug,                  \
>>               "Enable Thread SMR 
>> Statistics")                                \
>> \
>>    product(bool, Inline, 
>> true,                                               \
>>
>>
>> Thanks, in advance, for a quick review.
>>
>> Dan
>>
>



More information about the hotspot-runtime-dev mailing list