RFR (M) 8186903: Remove j-types from Atomic

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Fri Dec 8 20:24:18 UTC 2017


Thanks Dan!

On 12/8/17 3:18 PM, Daniel D. Daugherty wrote:
> On 12/6/17 4:59 PM, coleen.phillimore at oracle.com wrote:
>> Summary: Change parameter types from jlong, jint, jbyte to int64_t, 
>> int32_t and int8_t respectively
>>
>> Leave renaming functions for later change.
>>
>> Ran JPRT which builds more Oracle platforms, mach5 tier1-5 on 
>> windows/linux x64 and tier1 on solaris-sparcv9.  Also built Zero 
>> product mode (fails building fastdebug for some other reason).
>>
>> Other platforms: could you please test this patch?
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8186903.01/webrev
>
> src/hotspot/cpu/x86/stubGenerator_x86_32.cpp
>     No comments.
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp
>     No comments.
>
> src/hotspot/cpu/zero/stubGenerator_zero.cpp
>     No comments.
>
> src/hotspot/os_cpu/bsd_x86/atomic_bsd_x86.hpp
>     No comments.
>
> src/hotspot/os_cpu/bsd_x86/bsd_x86_32.s
>     No comments.
>
> src/hotspot/os_cpu/bsd_zero/atomic_bsd_zero.hpp
>     No comments.
>
> src/hotspot/os_cpu/linux_arm/atomic_linux_arm.hpp
>     No comments.
>
> src/hotspot/os_cpu/linux_arm/os_linux_arm.cpp
>     No comments.
>
> src/hotspot/os_cpu/linux_arm/os_linux_arm.hpp
>     No comments.
>
> src/hotspot/os_cpu/linux_sparc/os_linux_sparc.hpp
>     No comments.
>
> src/hotspot/os_cpu/linux_x86/atomic_linux_x86.hpp
>     No comments.
>
> src/hotspot/os_cpu/linux_zero/atomic_linux_zero.hpp
>     No comments.
>
> src/hotspot/os_cpu/solaris_sparc/os_solaris_sparc.hpp
>     No comments.
>
> src/hotspot/os_cpu/solaris_x86/atomic_solaris_x86.hpp
>     No comments.
>
> src/hotspot/os_cpu/solaris_x86/os_solaris_x86.cpp
>     No comments.
>
> src/hotspot/os_cpu/solaris_x86/os_solaris_x86.hpp
>     No comments.
>
> src/hotspot/os_cpu/windows_x86/atomic_windows_x86.hpp
>     No comments.
>
> src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp
>     No comments.
>
> src/hotspot/os_cpu/windows_x86/os_windows_x86.hpp
>     No comments.
>
> src/hotspot/share/runtime/atomic.hpp
>     No comments.
>
> src/hotspot/share/runtime/stubRoutines.cpp
>     No comments.
>
> src/hotspot/share/runtime/stubRoutines.hpp
>     No comments.
>
>
> Thumbs up.
>
> I'm also scratching my head on some of the switches to "long" usage,
> but it looks like you and David worked that out...
>

The ptr variants were removed except this one.  It should be some 64 bit 
entity which for the rest of the functions is currently 'long'. So I 
made it match.   It's a further cleanup (as always!)  Now all the ptr 
variants are gone.

Coleen
> Dan
>
>
>
>> bug link https://bugs.openjdk.java.net/browse/JDK-8186903
>>
>> This change is for JDK 11.
>>
>> Thanks,
>> Coleen
>>
>



More information about the hotspot-runtime-dev mailing list