RFR (M) 8186903: Remove j-types from Atomic

[Andrew Dinn]

On 08/12/17 12:36, coleen.phillimore at oracle.com wrote:
> On 12/8/17 6:52 AM, Andrew Dinn wrote:
>> On 06/12/17 21:59, coleen.phillimore at oracle.com wrote:
>>> Other platforms: could you please test this patch?
>> This built fine on AArch64 and successfully passed basic smoke tests
>> (runs javac and netbeans, passes jtreg tests for j.u.c).
>>
>> I am currently running jcstress tests just to be sure. If you want to
>> wait on the result of that I will let you know the result when they
>> finish (all is ok so far but there is still a long way to go).
> 
> Hi Andrew,  Did you also review the change?
> 
> There's no rush because this is waiting for JDK 11 to open up.
No, I didn't review the change. I think I will be doing so though
because I saw some failures when running jcstress.

Unfortunately, my AArch64 box fell over before the run completed so I
did nto get a complete set of results. However, I did record the 3
failures shown below.

I'll need to rerun with/without your change just to check whether it
really is the culprit.

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander

----- 8< -------- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---
  [FAILED] o.o.j.t.coherence.varHandles.fields.opaque.ShortTest
    (fork: #1, iteration #2, JVM args: [-XX:-TieredCompilation])
  Observed state   Occurrences   Expectation  Interpretation

          -1, -1     2,627,869    ACCEPTABLE  Observers sees both read.

           -1, 0             1     FORBIDDEN  Seeing first read, but not
second: coherence violation.
           0, -1            59    ACCEPTABLE  Observe second read, but
not first: sequential consistency.
            0, 0       133,151    ACCEPTABLE  Default value for the
fields. Allowed to see this: data r...

----- 8< -------- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---
  [FAILED] o.o.j.t.coherence.varHandles.fields.opaque.ShortTest
    (fork: #1, iteration #3, JVM args: [-XX:-TieredCompilation])
  Observed state   Occurrences   Expectation  Interpretation

          -1, -1    15,667,937    ACCEPTABLE  Observers sees both read.

           -1, 0             2     FORBIDDEN  Seeing first read, but not
second: coherence violation.
           0, -1         3,713    ACCEPTABLE  Observe second read, but
not first: sequential consistency.
            0, 0       751,608    ACCEPTABLE  Default value for the
fields. Allowed to see this: data r...

----- 8< -------- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---
  [FAILED] o.o.j.t.coherence.varHandles.fields.opaque.ByteTest
    (fork: #1, iteration #3, JVM args: [-XX:-TieredCompilation])
  Observed state   Occurrences   Expectation  Interpretation

          -1, -1    11,867,040    ACCEPTABLE  Observers sees both read.

           -1, 0             1     FORBIDDEN  Seeing first read, but not
second: coherence violation.
           0, -1           671    ACCEPTABLE  Observe second read, but
not first: sequential consistency.
            0, 0        74,538    ACCEPTABLE  Default value for the
fields. Allowed to see this: data r...

----- 8< -------- 8< -------- 8< -------- 8< -------- 8< -------- 8< ---