RFR[M] 8193672 - [test] Enhance vm.cds property to check for all conditions required to run CDS tests

Ioi Lam ioi.lam at oracle.com
Sun Dec 17 01:26:37 UTC 2017


Hi,

Please review this fix that touches many test cases with simple changes.

- https://bugs.openjdk.java.net/browse/JDK-8193672
- 
http://cr.openjdk.java.net/~iklam/jdk11/8193672.enhance.vm.cds.test.property.v01/


SUMMARY
=======

All the test changes look like this:

Before:

* AppCDS does not support uncompressed oops"
* @requires (vm.opt.UseCompressedOops == null) | 
(vm.opt.UseCompressedOops == true)

After:

* @requires vm.cds

This makes the tests easier to maintain, as we no longer need to
leak the implementation dependencies of CDS into all of the test cases.


The check for "(vm.opt.UseCompressedOops == null) | 
(vm.opt.UseCompressedOops == true)"
is now moved into whitebox.cpp (the first file in the webrev page).


TESTING
=======

Tested with hotspot tier1 and tier2, which include all the CDS tests.


Thanks!
- Ioi



More information about the hotspot-runtime-dev mailing list