RFR(one-liner): 8193514: UseMembar should not be obsoleted yet

[Doerr, Martin]

Hi Robbin,

thanks for changing. We appreciate the ability to switch it off for some time as long as the serialization page code doesn't disturb. Change looks good.

Best regards,
Martin


-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Karen Kinnear
Sent: Freitag, 15. Dezember 2017 15:45
To: Robbin Ehn <robbin.ehn at oracle.com>
Cc: hotspot-runtime-dev at openjdk.java.net
Subject: Re: RFR(one-liner): 8193514: UseMembar should not be obsoleted yet

Thanks Robbin for working this out with the community and for the change. Looks good.

Karen

> On Dec 15, 2017, at 8:27 AM, Robbin Ehn <robbin.ehn at oracle.com> wrote:
> 
> 
> On 12/15/2017 02:20 PM, Daniel D. Daugherty wrote:
>> On 12/15/17 8:12 AM, Robbin Ehn wrote:
>>> Hi, please review,
>>> 
>>> After discussion with platform maintainers we keep the option around in JDK 11 also. It's not decided which release it will obsoleted in, so we set it to a future one.
>> The bug info for this one is:
>> JDK-8193514 UseMembar should not be obsoleted yet
>> https://bugs.openjdk.java.net/browse/JDK-8193514 <https://bugs.openjdk.java.net/browse/JDK-8193514>
> 
> Thanks!
> 
>>> 
>>> Passes:
>>> open/test/hotspot/jtreg/runtime/CommandLine/
>>> 
>>> /Robbin
>>> 
>>> diff -r 6d4e1efac80a src/hotspot/share/runtime/arguments.cpp
>>> --- a/src/hotspot/share/runtime/arguments.cpp    Wed Dec 13 15:37:48 2017 -0800
>>> +++ b/src/hotspot/share/runtime/arguments.cpp    Fri Dec 15 14:04:38 2017 +0100
>>> @@ -499,3 +499,3 @@
>>>    { "InitialRAMFraction",           JDK_Version::jdk(10), JDK_Version::undefined(), JDK_Version::undefined() },
>>> -  { "UseMembar",                    JDK_Version::jdk(10), JDK_Version::jdk(11), JDK_Version::jdk(12) },
>>> +  { "UseMembar",                    JDK_Version::jdk(10), JDK_Version::undefined(), JDK_Version::undefined() },
>>>    { "FastTLABRefill",               JDK_Version::jdk(10), JDK_Version::jdk(11), JDK_Version::jdk(12) },
>> Thumbs up!
> 
> And thanks again!
> 
> /Robbin
> 
>> Dan