RFR(XS) 8193897 - JDK-8191374 caused windows_i586 build to fail
Ioi Lam
ioi.lam at oracle.com
Wed Dec 20 17:56:54 UTC 2017
Hi,
Please review this fix for jprt breakage.
I'd like to use the trivial fixrule since it affects JPRT.
https://bugs.openjdk.java.net/browse/JDK-8193897
--- a/src/hotspot/share/classfile/classLoader.cpp Tue Dec 19 11:29:07
2017 -0800
+++ b/src/hotspot/share/classfile/classLoader.cpp Wed Dec 20 09:44:58
2017 -0800
@@ -803,7 +803,7 @@
bool set_base_piece = true;
#if INCLUDE_CDS
- if (DumpSharedSpaces || UseSharedSpaces) {
+ if (DumpSharedSpaces) {
if (!Arguments::has_jimage()) {
vm_exit_during_initialization("CDS is not supported in exploded
JDK build", NULL);
}
The failure happens on 32-bit platforms where UseSharedSpaces is true by
default.
We actually just needed to check for DumpSharedSpaces and disable archive
creation for exploded builds.
Without an archive, the user won't be able to run with CDS using an
exploded build.
(Archive loading checks for the JVM which created the archive, so the
exploded build
can't use an archive created by another JVM).
Thanks
- Ioi
More information about the hotspot-runtime-dev
mailing list