RFR [11] JDK-8179424: Remove terminally deprecated sun.reflect.Reflection.getCallerClass
David Holmes
david.holmes at oracle.com
Thu Dec 21 09:29:32 UTC 2017
On 21/12/2017 7:20 PM, Chris Hegarty wrote:
> David,
>
>> On 21 Dec 2017, at 00:42, David Holmes <david.holmes at oracle.com> wrote:
>>
>> Hi Chris,
>>
>> Adding in hotspot-runtime-dev now that you have included the VM side of the cleanup. What repo are you planning on pushing this to?
>
> Since there are now changes in the hotspot area, then it
> probably makes sense to push this through jdk/hs.
Okay.
>> ...
>>
>> Can you fix an existing typo please:
>> ! * error if it is not marked propertly.
>> propertly -> properly
>
> Fixed.
>
>> Also you seem to have missed this test reference:
>> ./langtools/tools/jdeps/jdkinternals/src/p/Main.java: Class<?> caller = Reflection.getCallerClass(2);
>
> Oops. Adding langtools testing too.
>
> Updated webrev:
> http://cr.openjdk.java.net/~chegar/8179424/webrev.02/
I don't quite follow the change to the langtools test. Is it just trying
to reference something in jdk.unsupported? I don't know what the "patch"
does.
> What’s the correct set of tests and route into jdk/hs these
> days? I’ve not pushed there in a while.
I'll email you direct.
Thanks,
David
> -Chris.
>
More information about the hotspot-runtime-dev
mailing list