RFR (xs) 8172246: [TESTBUG] runtime/RedefineTests/RedefinePreviousVersions.java 'Class unloading: has_previous_vers,ions = true' missing from stdout/stderr

[Coleen Phillimore]

On 1/4/17 7:33 PM, David Holmes wrote:
> Hi Coleen,
>
> On 5/01/2017 9:05 AM, Coleen Phillimore wrote:
>> Summary: add boolean to gate redefinition start
>>
>> open webrev at http://cr.openjdk.java.net/~coleenp/8172246/webrev
>> bug link https://bugs.openjdk.java.net/browse/JDK-8172246
>
> Minor nit. Please change both:
>
> Thread.currentThread().sleep(10);
>
> to
>
> Thread.sleep(10);

Sure, I'll change it.
>
> sleep() always applies to the current thread.
>
> Also, as it is a boolean variable style dictates that:
>
> while (Running.running != true) {
>
> be written as:
>
> while (!Running.running) {
>

ok.

> One related query with this test: are we guaranteed that the loop of 
> System.gc() calls will trigger class unloading?
>

No, the test doesn't rely on that.  I did the system.gc so that I could 
see it when running the test but it doesn't need to deallocate the 
previous versions of the class.   And it doesn't deallocate them if the 
'infinite' method has been compiled because it hangs out in the code 
cache for a long time.

Thanks!
Coleen

> Thanks,
> David
>
>> Tested multiple times with new better test code.
>>
>> Thanks,
>> Coleen