RFR(S) 8172288: Fix error message when trying to define an existing package to a module

[George Triantafillou]

Hi Karen,

On 1/12/2017 9:26 AM, Karen Kinnear wrote:
> Harold,
>
> Looks good - with the same minor comment George caught, perhaps throw_dup_pkg_exception?
>
> George - there are two tests attached.
Thanks, I saw the additions to 
test/runtime/modules/JVMDefineModule.java, but I wanted to know which 
hotspot tests were run with Harold's change.

-George
>
> thanks,
> Karen
>
>> On Jan 12, 2017, at 9:18 AM, George Triantafillou <george.triantafillou at oracle.com> wrote:
>>
>> Hi Harold,
>>
>> src/share/vm/classfile/modules.cpp - lines 266, 449, and 806:
>>
>> Change "throw_dup_pkg_IAE" to "throw_dup_pkg_ISE".
>>
>> How was the change tested?  Thanks.
>>
>> -George
>>
>> On 1/12/2017 8:50 AM, harold seigel wrote:
>>> Hi,
>>>
>>> Please review this updated webrev for this bug.  The updated webrev includes a small JDK change and hotspot changes to throw the correct exceptions.
>>>
>>> New JDK webrev: http://cr.openjdk.java.net/~hseigel/bug_8172288.jdk.2/webrev/index.html
>>>
>>> New Hotspot webrev: http://cr.openjdk.java.net/~hseigel/bug_8172288.hs.2/
>>>
>>> Note also that the bug has been re-titled to: Fix Jigsaw related module/package error messages and throw correct exceptions
>>>
>>> Thanks, Harold
>>>
>>> On 1/10/2017 10:18 AM, harold seigel wrote:
>>>> Yes.  I'll modify the bug to include that.
>>>>
>>>> What exception should the JVM throw for this?
>>>>
>>>> Thanks, Harold
>>>>
>>>>
>>>> On 1/10/2017 10:12 AM, Alan Bateman wrote:
>>>>> On 10/01/2017 15:02, harold seigel wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Please review this small fix for JDK-8172288.  Here's a sample of the new message:
>>>>>>
>>>>>> Package mypackage6 for module dupl.pkg.module is already in another module, Module_A, defined to the class loader
>>>>>>
>>>>>> Adding the class loader name to the message will be done as part of JDK-8169559 <https://bugs.openjdk.java.net/browse/JDK-8169559>.
>>>>>>
>>>>>> Open Webrev: http://cr.openjdk.java.net/~hseigel/bug_8172288/webrev/index.html
>>>>> IllegalArgumentException isn't a good exception for these cases, is now the time to proposing this too?
>>>>>
>>>>> -Alan