RFR: 8170821: Ensure access checks result in consistent answers

[Rachel Protacio]

Thanks for the review, Harold! I'll add that.

Rachel


On 1/12/2017 10:25 AM, harold seigel wrote:
> Hi Rachel,
>
> The tests look good.  Could you just enhance some of the 
> IllegalAccessError catch clauses to call e.getMessage() to ensure that 
> the IllegalAccessError exceptions got thrown for the expected reasons?
>
> I don't need to see another webrev.
>
> Thanks, Harold
>
>
> On 1/11/2017 10:25 AM, Rachel Protacio wrote:
>> Hello! I've updated this changeset, if anyone wouldn't mind reviewing 
>> it again. http://cr.openjdk.java.net/~rprotacio/8170821.02
>>
>> Changes:
>>     - updated AccessExportTwice.java (previously "AccessTwice.java") 
>> because of API changes
>>     - corrected some comments
>>     - added AccessReadTwice.java test that ensures constant answers 
>> when IAE is due to readability (AccessExportTwice checks for 
>> exportedness)
>>
>> Tested with JPRT.
>>
>> Thanks!
>> Rachel
>>
>> On 12/9/2016 10:13 AM, Rachel Protacio wrote:
>>> Thanks, Harold -
>>>
>>> New webrev: http://cr.openjdk.java.net/~rprotacio/8170821.01/
>>>
>>>
>>> On 12/9/2016 9:09 AM, harold seigel wrote:
>>>> Hi Rachel,
>>>>
>>>> The test looks good, lots of good comments.  Just a couple of 
>>>> questions.
>>>>
>>>> 1. Does the test need to be run with -Xlog:modules=debug ?
>>> No, not really. It was there because it was helpful in the case that 
>>> the test fails, but you're right, it's extra effort/output now. I've 
>>> removed it.
>>>>
>>>> 2. Is -Xbootclasspath/a:. needed ?
>>> Nope, deleted that too.
>>> Thanks!
>>> Rachel
>>>>
>>>> Thanks, Harold
>>>>
>>>>
>>>> On 12/8/2016 4:18 PM, Rachel Protacio wrote:
>>>>> Hello!
>>>>>
>>>>> Please review this change adding a jtreg test to ensure that 
>>>>> access check results are cached, so the same check produces the 
>>>>> same answer even if the user adds access in between. (Credit to 
>>>>> Lois for the actual workings of the test.)
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8170821
>>>>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8170821.00/
>>>>>
>>>>> Passes JPRT on all platforms.
>>>>>
>>>>> Thanks,
>>>>> Rachel
>>>>>
>>>>
>>>
>>
>