RFR(XS): 8173163: searching for a versioned entry in a multi-release jar in hotspot is inconsistent with java code

Ioi Lam ioi.lam at oracle.com
Wed Jan 25 20:26:52 UTC 2017


Hi Calvin, the change looks good to me. Just a nit pick:

370         if (version < base_version) is_multi_ver = false;

I think the usual HotSpot coding style is:

370         if (version < base_version) {
               is_multi_ver = false;
             }

So it can be easily stepped over in a debugger.

Thanks
- Ioi



On 1/25/17 12:06 PM, Calvin Cheung wrote:
> Please review this simple bug fix for JDK 9.
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8173163
>
> webrev: http://cr.openjdk.java.net/~ccheung/8173163/webrev.00/
>
> thanks,
> Calvin



More information about the hotspot-runtime-dev mailing list