RFR(XS): 8173163: searching for a versioned entry in a multi-release jar in hotspot is inconsistent with java code

serguei.spitsyn at oracle.com serguei.spitsyn at oracle.com
Wed Jan 25 22:50:24 UTC 2017


It is good.

Thank you for the update,
Serguei

On 1/25/17 14:44, Calvin Cheung wrote:
> Thanks Serguei for your review.
>
> Based on your and Ioi's review comment, the change looks like the 
> following:
> +         // If the specified version is lower than the base version, 
> the base
> +         // entry will be used; if the version is higher than the 
> current
> +         // jdk version, the highest versioned entry will be used.
> +         if (version < base_version) {
>               is_multi_ver = false;
> +         }
>
> thanks,
> Calvin
>
> On 1/25/17, 12:51 PM, serguei.spitsyn at oracle.com wrote:
>> Hi Calvin,
>>
>>
>> Looks good.
>> Nit: The comments in this file normally start from a capital letter.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 1/25/17 12:06, Calvin Cheung wrote:
>>> Please review this simple bug fix for JDK 9.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8173163
>>>
>>> webrev: http://cr.openjdk.java.net/~ccheung/8173163/webrev.00/
>>>
>>> thanks,
>>> Calvin
>>



More information about the hotspot-runtime-dev mailing list