RFR: [8u] 8087342: crash in klassItable_initialize_itable_for_interface

[David Buck]

Hi!

Please review this backport of 8087342 to 8u-dev.

bug report: https://bugs.openjdk.java.net/browse/JDK-8087342

JDK 9 push: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/5e09f372116b

JDK 9 review thread (2 parts):
 
http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-July/015436.html
 
http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-August/015602.html

JDK 8u webrev: http://cr.openjdk.java.net/~dbuck/8087342_01/

The backport was relatively straightforward. The only minor complication 
was the refactoring done as part of 8067480 [0]. 8067480 itself did not 
need to be backported from 9 to 8u because that issue did not apply to 
8u by the time it was fixed in 9. But the refactoring done for 8067480 
seemed to be the only reasonable way to backport 8087342 and keep the 
code readable. (If I had just added yet another bool flag to each of 
these methods, it would have been *way* to easy to get parameters confused.)

So the best way to look at this changeset is as a backport of both 
8087342 and (most of) 8067480.

[0]
https://bugs.openjdk.java.net/browse/JDK-8067480
http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/d656b4c91d51
http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2015-January/013717.html

Cheers,
-Buck