RFR 8184281: -Xlog:startuptime does not include call to initPhase2

George Triantafillou george.triantafillou at oracle.com
Wed Jul 12 18:52:26 UTC 2017


Hi Harold,

Your changes look good.

-George

On 7/12/2017 2:19 PM, harold seigel wrote:
> Hi,
>
> Please review this updated webrev that has the changed message:
>
> http://cr.openjdk.java.net/~hseigel/bug_8184281.2/webrev/index.html
>
> Thanks, Harold
>
>
> On 7/12/2017 11:12 AM, Alan Bateman wrote:
>> On 12/07/2017 15:15, harold seigel wrote:
>>> Hi,
>>>
>>> Please review this small JDK-10 fix for JDK-8184281.  The fix drops 
>>> the need to specify "+module" in order to get Phase2 initialization 
>>> timer information.  It will now be included when just 
>>> -Xlog:startuptime is specified.
>>>
>>> Open Webrev: 
>>> http://cr.openjdk.java.net/~hseigel/bug_8184281/webrev/index.html
>>>
>>> JBS Bug: https://bugs.openjdk.java.net/browse/JDK-8184281
>> This looks good, I just wonder if we should change the message while 
>> in the area. When looking at -Xlog:startuptime output then I think it 
>> would be more useful to see "Initialize module system" for example.
>>
>> At some point we might need a TraceTime in call_initPhase3 too but 
>> it's mostly close to nothing so not important now.
>>
>> -Alan
>



More information about the hotspot-runtime-dev mailing list