RFR (M): 8184334: Generalizing Atomic with templates

Erik Österlund erik.osterlund at oracle.com
Mon Jul 17 09:04:05 UTC 2017


Hi Kim,

Thank you for the review. I have now fixed all the issues you mentioned.

New full webrev:
http://cr.openjdk.java.net/~eosterlund/8184334/webrev.01/

New incremental webrev:
http://cr.openjdk.java.net/~eosterlund/8184334/webrev.00_01/

Thanks,
/Erik

On 2017-07-14 20:56, Kim Barrett wrote:
>> On Jul 14, 2017, at 12:28 PM, Erik Österlund <erik.osterlund at oracle.com> wrote:
>>
>> Hi,
>>
>> Bug:
>> https://bugs.openjdk.java.net/browse/JDK-8184334
>>
>> Webrev:
>> http://cr.openjdk.java.net/~eosterlund/8184334/webrev.00/
> ------------------------------------------------------------------------------
> Another pre-review comment that seems to have been missed.  (Your
> reply indicated the suggestion was accepted.)
>
> src/share/vm/runtime/atomic.hpp
>   250   typedef typename IntegerTypes::Signed<intptr_t>::type Raw;
> intptr_t => U*
>
>   269     typedef typename IntegerTypes::Signed<intptr_t>::type Raw;
>   286     typedef typename IntegerTypes::Signed<intptr_t>::type Raw;
> intptr_t => T*
>
> ------------------------------------------------------------------------------
>



More information about the hotspot-runtime-dev mailing list