RFR[XS] (10) 8181860 [TESTBUG] serviceability/tmtools/jstack/utils/DefaultFormat.java does not recognize "sleeping" state

[Ioi Lam]

Thanks Dan & George. I am pushing now.

- Ioi


On 7/19/17 7:11 AM, George Triantafillou wrote:
> +1
>
> -George
>
> On 7/18/2017 2:25 PM, Daniel D. Daugherty wrote:
>> On 7/17/17 7:47 PM, Ioi Lam wrote:
>>> https://bugs.openjdk.java.net/browse/JDK-8181860
>>>
>>> This failure has shown up in the past few months with hotspot tier 2
>>> testing. Apparently "sleeping" has been a valid state for a long time
>>> so I don't know why the failure showed up only recently.
>>>
>>> FYI, I ran some casual testing and the tests failed on linux/x64 but 
>>> not
>>> windows/x64.
>>>
>>> ==================================================
>>>
>>> $ hg diff
>>> diff -r ba869214a302 
>>> test/serviceability/tmtools/jstack/utils/DefaultFormat.java
>>> --- a/test/serviceability/tmtools/jstack/utils/DefaultFormat.java 
>>> Mon Jul 17 09:21:48 2017 -0700
>>> +++ b/test/serviceability/tmtools/jstack/utils/DefaultFormat.java 
>>> Mon Jul 17 18:30:48 2017 -0700
>>> @@ -55,7 +55,7 @@
>>>      protected String threadInfoPattern() {
>>>          return 
>>> "^\"(.*)\"\\s(#\\d+\\s|)(daemon\\s|)prio=(.+)\\s(os_prio=(.+)\\s|)tid=(.+)\\snid=(.+)\\s(" 
>>>
>>>                  + Consts.UNKNOWN
>>> - + 
>>> "|runnable|waiting\\son\\scondition|in\\sObject\\.wait\\(\\)|waiting\\sfor\\smonitor\\sentry)((.*))$"; 
>>>
>>> + + 
>>> "|runnable|sleeping|waiting\\son\\scondition|in\\sObject\\.wait\\(\\)|waiting\\sfor\\smonitor\\sentry)((.*))$"; 
>>>
>>>      }
>>
>> The threadInfoPattern() is general purpose and is supposed
>> to recognize the "thread info" line from jstack output. I
>> agree that "sleeping" is missing here (along with some
>> other values).
>>
>> Thumbs up!
>>
>> Dan
>>
>>
>>
>>>
>>> ==================================================
>>>
>>> Thanks
>>> Ioi
>>>
>>
>