RFR: 8175318: Performance issue regarding local JNI references

Kim Barrett kim.barrett at oracle.com
Thu Jul 20 23:54:50 UTC 2017


> On Jul 19, 2017, at 11:34 AM, Volker Simonis <volker.simonis at gmail.com> wrote:
> 
> Looks good!
> 
> You could use:
> 
> +        for ( current = current->_next; current != NULL; current =
> current->_next) {
> 
> instead of:
> 
> +        for ( ; current != NULL; current = current->_next) {
> 
> in the debug code as you already now that the first 'top' is NULL.
> But that's nit picking. I'll leave it up to you if you want to do that.
> There's also no need for a new webrev in case you do that change.
> 
> Thank you and best regards,

Thanks.

I made this change, since I was already making the other change of eliminating
the unused clear() function (mentioned in previous email).  I also deleted a bit of
whitespace that made it harder to search for “_top = 0”.  I think those only show up
in the patch view.

new webrevs:
full: http://cr.openjdk.java.net/~kbarrett/8175318/hotspot.01/
incr: http://cr.openjdk.java.net/~kbarrett/8175318/hotspot.01.inc/





More information about the hotspot-runtime-dev mailing list