[s390] RFR(XS): 8184267: Restore register from stack uses wrong offset

[Doerr, Martin]

Hi Lutz,

thanks for fixing this obvious bug. Reviewed and pushed.

Best regards,
Martin

-----Original Message-----
From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-bounces at openjdk.java.net] On Behalf Of Schmidt, Lutz
Sent: Montag, 17. Juli 2017 16:23
To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-runtime-dev at openjdk.java.net
Subject: Re: [s390] RFR(XS): 8184267: Restore register from stack uses wrong offset

Thank you, Goetz!

Regards, Lutz


 

On 17.07.2017, 16:16, "Lindenmaier, Goetz" <goetz.lindenmaier at sap.com> wrote:

    Hi Lutz, 
    
    took me a while to see the bug, good catch :)
    Looks good.
    
    Goetz.
    
    > -----Original Message-----
    > From: hotspot-runtime-dev [mailto:hotspot-runtime-dev-
    > bounces at openjdk.java.net] On Behalf Of Schmidt, Lutz
    > Sent: Mittwoch, 12. Juli 2017 14:30
    > To: hotspot-runtime-dev at openjdk.java.net
    > Subject: [s390] RFR(XS): 8184267: Restore register from stack uses wrong
    > offset
    > 
    > Dear community,
    > 
    > may I please request reviews for this little s390-only bug fix? It corrects the
    > offset used to restore a previously saved argument register value. At the
    > same time, the save/restore code is improved by the use of “store multiple”
    > and “load multiple” instructions.
    > 
    > Bug: https://bugs.openjdk.java.net/browse/JDK-8184267
    > Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8184267.00/
    > 
    > Thank you very much!
    > Lutz