RFR(XXS) [10] 8183038 Minimal vm slowdebug build fails with undefined reference to MetaspaceShared::is_valid_shared_method

[Jiangli Zhou]

Looks good. Any idea why it only fails with slowdebug build?

Thanks,
Jiangli

> On Jul 24, 2017, at 3:57 PM, Ioi Lam <ioi.lam at oracle.com> wrote:
> 
> Hi, please review this very simple fix. We need to add NOT_CDS_RETURN_(false).
> 
> https://bugs.openjdk.java.net/browse/JDK-8183038
> 
> diff -r 5d56055dcb81 src/share/vm/memory/metaspaceShared.hpp
> --- a/src/share/vm/memory/metaspaceShared.hpp    Sat Jul 22 10:03:15 2017 +0200
> +++ b/src/share/vm/memory/metaspaceShared.hpp    Mon Jul 24 15:54:39 2017 -0700
> @@ -181,7 +181,7 @@
>   static intptr_t* clone_cpp_vtables(intptr_t* p);
>   static void zero_cpp_vtable_clones_for_writing();
>   static void patch_cpp_vtable_pointers();
> -  static bool is_valid_shared_method(const Method* m);
> +  static bool is_valid_shared_method(const Method* m) NOT_CDS_RETURN_(false);
> 
>   static void serialize(SerializeClosure* sc, GrowableArray<MemRegion> *string_space,
>                         size_t* space_size);
> 
> 
> 
> Thanks
> - Ioi