8184749: The solaris_x86_32.s and solaris_x86_32.il files should be removed

Daniel D. Daugherty daniel.daugherty at oracle.com
Tue Jul 25 17:40:16 UTC 2017


Agreed that the change looks good.

Thumbs up!

Since this changeset is about removal of two files that shouldn't be
used by the build, does this qualify under the HotSpot Trivial Change
rule? I would vote yes...

Dan


On 7/25/17 11:37 AM, harold seigel wrote:
> Hi George,
>
> The change looks good.
>
> Harold
>
>
> On 7/25/2017 1:31 PM, George Triantafillou wrote:
>> Please review this very small JDK-10 enhancement to remove unused 
>> Solaris assembly files:
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8184749
>> webrev: 
>> http://cr.openjdk.java.net/~gtriantafill/8184749-webrev/webrev/ 
>> <http://cr.openjdk.java.net/%7Egtriantafill/8184749-webrev/webrev/>
>>
>> The change was tested by building on Solaris sparcv9/x64.
>>
>> Thanks.
>>
>> -George
>>
>
>



More information about the hotspot-runtime-dev mailing list