RFR(s): 8181319: Make os::Linux::sched_getcpu() available even when UseNUMA is false

Per Liden per.liden at oracle.com
Thu Jun 1 09:21:58 UTC 2017


Thanks for reviewing David and Robbin!

cheers,
Per

On 2017-06-01 08:37, Robbin Ehn wrote:
> Hi Per,
>
> On 06/01/2017 03:42 AM, David Holmes wrote:
>> Hi Per,
>>
>> On 31/05/2017 9:59 PM, Per Liden wrote:
>>> Hi,
>>>
>>> The initialization/availability of os::Linux::sched_getcpu() is today
>>> guarded by UseNUMA. While NUMA-related code is currently the only
>>> user of sched_getcpu(), this function is useful in many other
>>> situations as well. I propose that we initialize
>>> os::Linux::sched_getcpu() regardless of whether UseNUMA is enabled or
>>> not.
>>
>> Looks fine.
>
> +1
>
> /Robbin
>
>>
>> Thanks,
>> David
>> -----
>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8181319
>>> Webrev: http://cr.openjdk.java.net/~pliden/8181319/webrev.0/
>>> Testing: JPRT, ad-hoc runs using ParallelGC with and without UseNUMA
>>>
>>> cheers,
>>> Per


More information about the hotspot-runtime-dev mailing list