RFR: 8176132:-XX:+PrintSharedSpaces should be converted to use Unified Logging.

Jiangli Zhou jiangli.zhou at oracle.com
Thu Jun 1 21:46:50 UTC 2017


Hi Rachel,

Looks good!

Thanks,
Jiangli

> On Jun 1, 2017, at 10:46 AM, Rachel Protacio <rachel.protacio at oracle.com> wrote:
> 
> Hello!
> 
> Please review this change converting +XX:+PrintSharedSpaces to Unified Logging, of the form -Xlog:cds=info. The WizardMode and Verbose statements correspond to "trace" level logging, according to the standard conversions. Additionally, the tag combinations "cds+hashtables", "cds+verification", and "cds+vtables=debug" split up the output into more manageable/helpful portions.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8176132
> Open webrev: http://cr.openjdk.java.net/~rprotacio/8176132.00/
> And test/lib/jdk/test/lib/cds/CDSTestUtils.java change at the foot of this email.
> 
> Tested with JPRT.
> 
> Thank you!
> Rachel
> 
> 
> ------
> 
> --- a/test/lib/jdk/test/lib/cds/CDSTestUtils.java
> +++ b/test/lib/jdk/test/lib/cds/CDSTestUtils.java
> @@ -65,7 +65,7 @@
>         for (String p : opts.prefix) cmd.add(p);
> 
>         cmd.add("-Xshare:dump");
> -        cmd.add("-XX:+PrintSharedSpaces");
> +        cmd.add("-Xlog:cds,cds+hashtables");
>         cmd.add("-XX:+UnlockDiagnosticVMOptions");
>         if (opts.archiveName == null)
>             opts.archiveName = getDefaultArchiveName();



More information about the hotspot-runtime-dev mailing list