RFR: 8176132:-XX:+PrintSharedSpaces should be converted to use Unified Logging.

[Ioi Lam]

Hi Rachel,

The changes look good. Just  one question:

filemap.cpp: is ResourceMark necessary here?

  103       if (log_is_enabled(Info, cds)) {
  104         ResourceMark rm;
  105         outputStream* logstream = Log(cds)::info_stream();
  106         logstream->print("UseSharedSpaces: ");
  107         logstream->vprint_cr(msg, ap);

Thanks

- Ioi



On 6/1/17 10:46 AM, Rachel Protacio wrote:
> Hello!
>
> Please review this change converting +XX:+PrintSharedSpaces to Unified 
> Logging, of the form -Xlog:cds=info. The WizardMode and Verbose 
> statements correspond to "trace" level logging, according to the 
> standard conversions. Additionally, the tag combinations 
> "cds+hashtables", "cds+verification", and "cds+vtables=debug" split up 
> the output into more manageable/helpful portions.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8176132
> Open webrev: http://cr.openjdk.java.net/~rprotacio/8176132.00/
> And test/lib/jdk/test/lib/cds/CDSTestUtils.java change at the foot of 
> this email.
>
> Tested with JPRT.
>
> Thank you!
> Rachel
>
>
> ------
>
> --- a/test/lib/jdk/test/lib/cds/CDSTestUtils.java
> +++ b/test/lib/jdk/test/lib/cds/CDSTestUtils.java
> @@ -65,7 +65,7 @@
>          for (String p : opts.prefix) cmd.add(p);
>
>          cmd.add("-Xshare:dump");
> -        cmd.add("-XX:+PrintSharedSpaces");
> +        cmd.add("-Xlog:cds,cds+hashtables");
>          cmd.add("-XX:+UnlockDiagnosticVMOptions");
>          if (opts.archiveName == null)
>              opts.archiveName = getDefaultArchiveName();