RFR: 8181859: Monitor deflation is not checked in cleanup path

Carsten Varming varming at gmail.com
Wed Jun 14 14:12:51 UTC 2017


Dear Robbin,

New code looks good to me.

Carsten

On Wed, Jun 14, 2017 at 9:24 AM, Robbin Ehn <robbin.ehn at oracle.com> wrote:

> Hi,
>
> On 06/14/2017 01:03 PM, Aleksey Shipilev wrote:
>
>> On 06/14/2017 11:40 AM, Robbin Ehn wrote:
>>
>>> static bool monitors_used_above_threshold() {
>>>    int monitors_used = gMonitorPopulation - gMonitorFreeCount;
>>>    int monitor_useage = (monitors_used * 100LL) / gMonitorPopulation;
>>>    return monitor_useage > MonitorUsedDeflationThreshold;
>>> }
>>>
>>
>> s/useage/usage/
>>
>
> Fixed.
>
>
>> bool ObjectSynchronizer::is_cleanup_needed() {
>>>    if (MonitorUsedDeflationThreshold > 0) {
>>>      return monitors_used_above_threshold();
>>>    }
>>>    return false;
>>> }
>>>
>>> Carsten, Aleksey, are you good with this?
>>>
>>> Full: http://cr.openjdk.java.net/~rehn/8181859/3/webrev/
>>>
>>
>> Good.
>>
>
> Thanks, but see other mail, error in my calculation.
>
> /Robbin
>
>
>> -Aleksey
>>
>>


More information about the hotspot-runtime-dev mailing list