RFR (S) 8183198: Factor out thread state serialization into a proper helper function

Mikael Gerdin mikael.gerdin at oracle.com
Thu Jun 29 09:42:18 UTC 2017

Hi Thomas,

On 2017-06-29 11:40, Thomas Schatzl wrote:
> Hi,
> On Thu, 2017-06-29 at 10:50 +0200, Mikael Gerdin wrote:
>> Hi all,
>> Please review this small cleanup of the thread state serialization
>> code.
>> Basically I suggest that we get rid of the platform specific
>> interfaceSupport headers, put the Windows specific exception wrapper
>> code in os_windows and let the other platforms share a os_posix
>> variant.
>> I've also tried to name the helper functions to clarify what the
>> difference between them is.
>> Testing: JPRT, local testing
>> Webrev: http://cr.openjdk.java.net/~mgerdin/8183198/webrev.0/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8183198
>    the refactoring looks good to me, but I would guess you want to wait
> for somebody from the runtime team too.

Thanks for the review, I plan to wait for a runtime person to OK it as well.


> Thanks,
>    Thomas

More information about the hotspot-runtime-dev mailing list