RFR: 8183232: Avoid resolving method_kind in AbstractInterpreter::can_be_compiled

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Thu Jun 29 16:25:00 UTC 2017


I think this looks good and is a nice cleanup.
thanks,
Coleen

On 6/29/17 12:13 PM, Claes Redestad wrote:
> Hi all,
>
> it appears profitable for startup to simplify 
> AbstractInterpreter::can_be_compiled
> to use methodHandle->intrinsic_id() rather than take a detour through 
> method_kind.
>
> webrev: http://cr.openjdk.java.net/~redestad/8183232/hotspot.00/
> bug: https://bugs.openjdk.java.net/browse/JDK-8183232
>
> Note: Having platform-dependent implementations for can_be_compiled 
> seems excessive,
> since if the intrinsic isn't implemented the corresponding case will 
> never trigger anyway.
> No regression can be detected on platforms that doesn't have certain 
> intrinsics, such as
> SPARC, but if there's preference I can revert to having 
> platform-dependent methods.
>
> Testing: JPRT
>
> Thanks!
>
> /Claes



More information about the hotspot-runtime-dev mailing list